Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repoinfo: Implement JSON output #1529

Merged
merged 3 commits into from
Jun 6, 2024
Merged

repoinfo: Implement JSON output #1529

merged 3 commits into from
Jun 6, 2024

Conversation

jan-kolarik
Copy link
Member

Turn on quiet mode when --json is requested. Also fixed suppressing repository download progress when quiet mode is turned on.

For: #867.

libdnf5-cli/output/repo_info.cpp Outdated Show resolved Hide resolved
libdnf5-cli/output/repo_info.cpp Outdated Show resolved Hide resolved
libdnf5-cli/output/repo_info.cpp Outdated Show resolved Hide resolved
So that only the json is printed and it is parsable.
Otherwise `quiet` is not parsed yet.
@kontura
Copy link
Contributor

kontura commented Jun 6, 2024

Thank you.

@kontura kontura added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 328dcea Jun 6, 2024
14 of 15 checks passed
@kontura kontura deleted the jkolarik/repoinfo-json branch June 6, 2024 10:09
@kontura
Copy link
Contributor

kontura commented Jun 6, 2024

Oh I also forgot to mention, I think it would be good to have some tests for the --json option.
Plus it would be nice to have a test for the --refresh --quiet combo.

@jan-kolarik
Copy link
Member Author

jan-kolarik commented Jun 6, 2024

Yep, sure. Thanks for the notice. I will create a follow-up ticket for that. I was planning to do so, but forgot to mention it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants